feat: Support Qv2 CLI social login #3060
Open
+1,380
−206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kensave
changed the title
kensave
reviewed
Oct 6, 2025
| IdentityFuture::new_boxed(Box::pin(async { | ||
| let database = Database::new().await?; | ||
|
|
||
| if let Ok(Some(token)) = builder_id::BuilderIdToken::load(&database).await { |
There was a problem hiding this comment.
Why do we need to check both all times?
There was a problem hiding this comment.
The UnifiedBearerResolver needs to support two login paths — Builder ID and Social.
A user may complete login through either method. Therefore, during the resolution phase, we need attempt both methods
* feat: New continuation id logic * chore: Centralize metadata * chore: Moves struct to right place --------- Co-authored-by: Kenneth S. <[email protected]>
dingfeli
reviewed
Oct 15, 2025
kensave
approved these changes
Oct 24, 2025
kkashilk
force-pushed
the
qv2
branch
2 times, most recently
from
83daff1 to
de21929
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Integrates with unified authentication portal supporting Google, GitHub, BuilderID, AWS IdC, and Internal auth methods.
Local environments: Browser-based OAuth flow via unified portal
Remote environments: Existing device flow (BuilderID/IdC(Internal))
User Experience
Local:
q login
Remote:
q login (--use-decivce-code)existing auth flow, prompted user that social login is not supported here
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.